Save logs to file and rotate it #270
Conversation
|
golangci-lint run is ok in local machine, submit go.sum, please check again |
cmd/server/main.go
Outdated
|
|
||
| func init() { | ||
| flag.StringVar(&configPath, "c", "config/config.yaml", "set config yaml file path") | ||
| flag.StringVar(&configPath, "c", "config/config-raft.yaml", "set config yaml file path") |
There was a problem hiding this comment.
We could keep config.yaml as its default configuration.
config/config-consul.yaml
Outdated
| min_alive_size: 5 | ||
| min_alive_size: 5 | ||
|
|
||
| log: |
There was a problem hiding this comment.
Can comment out those lines to keep the stdout as its default output.
config/config-raft.yaml
Outdated
| ping_interval_seconds: 3 | ||
| min_alive_size: 5 | ||
|
|
||
| log: |
config/config-zk.yaml
Outdated
| min_alive_size: 5 | ||
| min_alive_size: 5 | ||
|
|
||
| log: |
|
@greatsharp Thanks for your contribution. |
|
how to run the golangci-lint, i run it locally, but no errors |
|
@greatsharp You need to run the lint command before committing the changed codes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #270 +/- ##
============================================
+ Coverage 43.38% 46.26% +2.88%
============================================
Files 37 45 +8
Lines 2971 4286 +1315
============================================
+ Hits 1289 1983 +694
- Misses 1544 2095 +551
- Partials 138 208 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 participants
No description provided.